[Webkit-unassigned] [Bug 179817] [WPE] Build C API tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179817

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 327165
  --> https://bugs.webkit.org/attachment.cgi?id=327165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327165&action=review

>> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:68
>> +        delete m_window;
> 
> delete is NULL-safe, so remove the if (m_window) check.

Right!

>> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:89
>> +    // FIXME: implement this.
> 
> What happened to using notImplemented()? :D

notImplemented() is WebCore API.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171117/810ef798/attachment.html>