[Webkit-unassigned] [Bug 179814] [Win] forwarding headers should not be copies

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 17 06:29:22 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=179814

--- Comment #18 from Mark Salisbury <mark.salisbury at hp.com> ---
(In reply to Konstantin Tokarev from comment #17)
> WPE uses Source/WebKit/Scripts/generate-forwarding-headers.pl which should
> generate all needed forwarding headers (maybe you need to add --platform win
> there though)

PlatformWin, GTK, and WPE all use that script.

You have a good point though.  Why was the xcopy forwarding header script ever added in the first place?  I'll look at the history when this was introduced.

It produces far more forwarding headers for JavaSriptCore than Source/WebKit/Scripts/generate-forwarding-headers.pl does...

Until I have an answer I would suggest not taking this patch.  I think there's still a problem here (xcopy causes problems) but I'm not sure I'm solving it in the right way.

Is there a way to clear review? commit-queue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171117/b862a080/attachment.html>


More information about the webkit-unassigned mailing list