[Webkit-unassigned] [Bug 179814] [Win] forwarding headers should not be copies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179814

--- Comment #15 from Mark Salisbury <mark.salisbury at hp.com> ---
(In reply to Konstantin Tokarev from comment #14)
> Actually I don't think you need to mess with this code at all, if you are
> only interested in WPE

While brining up a WPE build on Windows we discovered that we needed the forwarding headers for JavaScriptCore.  We copied the same xcopy code that Windows builds use.  Then later I started getting zillions of compile errors from multiply defined symbols.  Some even caused compiler crashes.

So I analyzed the problem, decided the root of the problem was exactly what this bug says.

As far as how we might introduce a WPE build on Windows, it'd be nice to avoid copying the code but perhaps locating common OS(WINDOWS) code to one place.  Even if we don't do that, I think it still is logical to fix this for Windows builds too.  I think they will likely see it sooner or later.

If you guys don't believe this is fundamentally a potential problem (of copying headers), then we can close this bug.

Thanks for your time so far!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171117/4bab0a64/attachment.html>