[Webkit-unassigned] [Bug 179814] [Win] forwarding headers should not be copies

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 17 05:08:05 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=179814

--- Comment #11 from Mark Salisbury <mark.salisbury at hp.com> ---
OK, on the first suggestion - scrap the preBuild.cmd on postBuild.cmd scripts - I tried again.

I'm running into a problem with quotes and I think *maybe* this is why these were written as .cmd files in the first place.

CMake uses one set of rules for quoting strings when writing to a file, which seem sane, but for building up a string directly quotes get wonky fast.

For example, a line like this:

  set(var "${var}here is some text \"now it is quoted\"")

ends up leaving the quotes at the beginning and end of the line.  and the escapes are also left in.

I also tried this:

  set(var ${var}here is some text "now it is quoted")

this takes quotes out completely.

And this:

  set(var ${var}here is some text \"now it is quoted\")

leaves the escapes in.

So I'm going to stick with .cmd files unless someone can show me an example of how to concatenate strings with quotes successfully.

I'm thinking not to '&&' all the script invocations together because there is a limit on how many characters you can have for a single command.  I read it's 8192 chars and we're very close to that.

As far as globbing all the dirs together for a single invocation, I'm trying to do what I think is a little easier to read.  It seems to execute plenty fast with multiple invocations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171117/c5840b0d/attachment.html>


More information about the webkit-unassigned mailing list