[Webkit-unassigned] [Bug 179495] AX: AOM: Implement string type properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179495

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 327101
  --> https://bugs.webkit.org/attachment.cgi?id=327101
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327101&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2500
> +    const AtomicString& ariaPlaceholder = stringValueForProperty(AXPropertyName::Placeholder);

if this is still atomic why did the return type change?

> Source/WebCore/accessibility/AccessibilityObject.h:704
> +    const String ariaKeyShortcutsValue() const;

should we remove aria as a prefix since this does AOM and aria

> Source/WebCore/accessibility/AccessibilityObject.h:985
> +    virtual const String ariaLiveRegionRelevant() const { return nullAtom(); }

ditto about these method names with aria

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171116/baac9e2b/attachment-0001.html>