[Webkit-unassigned] [Bug 179714] [Touch Bar Web API] Object representing Touch Bar Menu to send between Web and UI Processes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179714

--- Comment #13 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Ryosuke Niwa from comment #10)
> Comment on attachment 326998 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326998&action=review
> 
> > Source/WebCore/html/HTMLMenuElement.cpp:44
> > +        if (auto* page = document().page())
> > +            page->chrome().client().didInsertMenuElement(*this);
> 
> This code is almost certainly wrong. This function gets called whenever a
> this menu element is inserted into some ancestor
> regardless of whether it's in a document or not. You need to check type to
> see if it's in the document or not.

+1

> It's very important that didInsertMenuElement never tries to execute any
> scripts.

Indeed!

> Are you sure this new ChromeClient callback wouldn't do that?

The purpose of these ChromeClient callbacks should just be to grab some (non-layout-dependent) information out of the element and send it over to the UI process, so I think we should be okay...we just need to be careful we don't ask the HTMLMenuElement or HTMLMenuItemElement any questions that trigger layout :/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171116/f4ac291d/attachment-0001.html>