[Webkit-unassigned] [Bug 179494] AX: AOM: Implement AccessibleNode class and support label and role attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179494

--- Comment #27 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 326899
  --> https://bugs.webkit.org/attachment.cgi?id=326899
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326899&action=review

>> Source/WebCore/accessibility/AccessibleNode.h:39
>> +typedef Variant<std::nullptr_t, String, bool, int> PropertyValueVariant;
> 
> When is nullptr_t used?

will remove.

>> LayoutTests/accessibility/accessibility-object-model.html:114
>> +        gc();
> 
> Why gc()? Something is not right if you need to call gc() to make the test run property.

Sure I will remove this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171115/759dcf3c/attachment.html>