[Webkit-unassigned] [Bug 179690] [MSE] Use correct range end checks in sourceBufferPrivateDidReceiveSample()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179690

--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
(In reply to Jer Noble from comment #2)
> Thanks for writing these tests. But I'm curious what the behavior of this
> change is when faced with appends like:
> 
> // PTS, duration
> [0, 2]
> [2, 2]
> [1, 2]
> 
> I would argue that the correct results would be:
> 
> buffered.length == 1
> buffered.start(0) == 1
> buffered.end(0) == 3
> 
> I'm not sure what this patch's results would be, as it stands.

I modified the test from your patch to issue appends in the order I specified above, and when run against ToT (i.e., without your fix), it gets:

{PTS({0/1000 = 0.000000}), DTS({0/1000 = 0.000000}), duration({2000/1000 = 2.000000}), flags(1), generation(0)}
{PTS({1000/1000 = 1.000000}), DTS({1000/1000 = 1.000000}), duration({2000/1000 = 2.000000}), flags(1), generation(0)}
EXPECTED (sourceBuffer.buffered.length == '1') OK
EXPECTED (sourceBuffer.buffered.start(0) == '0') OK
EXPECTED (sourceBuffer.buffered.end(0) == '3') OK

So it removes the second sample, but not the first, and leaves overlapping samples in the track buffer, which I think is incorrect.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171114/f8052ec0/attachment.html>