[Webkit-unassigned] [Bug 170272] MathML: Extra left space for arrows inside <mo>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170272

--- Comment #25 from Minsheng Liu <lambda at liu.ms> ---
> So this patch fixes your initial test case, right? What about the centering, do we still need it? I actually wonder whether it was because the actual size of the stretched operator does not necessarily match the target size (so it would still be more beautiful to do a centering... but ignoring lspace/rspace to avoid this bug)?

The updated computeOperatorHorizontalStretch(), plus the fix in stretchTo() that updates the logical width, should match the actual size of the stretched operator with the target size, rendering centering unnecessary. I think our general aim should to match these two sizes as they give better bounds in the Inspector. Therefore, removing the center code once and for all should be fine, and if we find any further issue on those, we could fix them independently.

By the way, I think the patch, if accepted, would not get into mainstream Safari until next September, so we have plenty of time to catch them…I am unsure about other platforms. 😂


> So I propose you open a preliminary cleanup bug to rename "computeOperatorsHorizontalStretch" to "stretchHorizontalOperatorsAndLayoutChildren" and remove the useless layoutIfNeeded calls, so that things are a bit clearer. That won't require new tests and you would be able to experience the contribution process.

Ok, my plan will be handle them in three steps:

1. Cleanup layout code in RenderMathMLUnderOver.cpp.
2. Rework stretchHorizontalOperatorsAndLayoutChildren() so that it gives correct bounds. This one requires some test using getBoundingClientRect().
3. Remove the center code and closes this issue.

By the way, is there any other environment where an operator might be stretched? If so, I could look at them manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171114/72b979dd/attachment.html>