[Webkit-unassigned] [Bug 170272] MathML: Extra left space for arrows inside <mo>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170272

--- Comment #20 from Minsheng Liu <lambda at liu.ms> ---
Created attachment 326859

  --> https://bugs.webkit.org/attachment.cgi?id=326859&action=review

fix the algorithm of layout <mover>/<munder> when stretchy operators are present

The fix is simple: I force the layout of all blocks containing stretchy operators. The cost is not that high, as children of those blocks do not need layout and hence all the extra computation is to recalculate the location. Moreover, Inspector now gives the correct bounds of those elements.

I have tested the code manually against the torture test and it does not break the original bug, the arrow centering issue.

Could you look at my changes and check if I satisfy the coding guidelines? I am not very familiar with C++ and its OOP capabilities, and while I have read the coding style guidelines, I might forget some. But I think the reviewer should handle that anyway.

---

About tests. I work on macOS High Sierra. I would like to continue my work but I have to sleep right now. Hopefully I could finish tests before the Friday. I am a third year undergraduate (major in not CS but math) so the course load is not light.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171114/83e406e1/attachment.html>