[Webkit-unassigned] [Bug 179605] [GTK] Test editing/execCommand/underline-selection-containing-image.html fails since added in r224649

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179605

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Wenson Hsieh from comment #1)
> Thank you for reporting this! If it's okay with you, perhaps we should skip
> the test on  the non-Cocoa platforms?

I marked it as failure on GTK+ already.

> Alternately, since this test was originally just checking that we don't hit
> a debug assertion, I could relax the requirements for this test and just
> check that textContent is "foo" at the end, instead of requiring an
> underline.

That would work I think, let me know if you want me to try any patch.

> > But that's not happening in GTK+, Underline command is not modifying the
> > tree (I guess because it's applied to the selection that is considered
> > empty), so next command just inserts the text replacing the selection (img).
> 
> Interesting...does the "Underline" command here have no effect, or is it
> that the command applies an inline text decoration style rather than
> wrapping the selection in an underline tag? If it's the latter, I can fix
> this test by examining the computed style of the text node "foo" for a text
> decoration.

I think it doesn't have effect, because foo is not underlined. I think it's because it's applied to the selection that is later replaced by the text, but I'm not sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171113/fb9ece0c/attachment.html>