[Webkit-unassigned] [Bug 170272] MathML: Extra left space for arrows inside <mo>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170272

--- Comment #13 from Minsheng Liu <lambda at liu.ms> ---
Created attachment 326734

  --> https://bugs.webkit.org/attachment.cgi?id=326734&action=review

a proposed patch

Truly stretched operator requires the special centering code I proposed to delete. The reason is that the stretchTo function does not update the element’s width (but does change that of m_mathOperator). My proposed patch changes that, and everything works fine.

Regarding to pixel test regression, I got six failed, but five of them failed without changing any code, so I am not sure if expected images need to be updated. The only case *I think* that is relevant is mathml/opentype/opentype-stretchy-horizontal. My patch passed the pixel test but has different text output (render tree). Nonetheless, I compared patched image output with unmatched output with my eyes and I think the patch gives the correct behavior.

I need the following help:
1. I am unsure about how to create a pixel test. I create one, and run the pixel test. It seems that WebKit automatically included it into the test case. Is that all I need to do? How about other platforms where expected images have not been created?

2. How to fix the five failed pixel tests. I am pretty sure that my code does not change the behavior of WebCore (I compared the result with the unmatched build). Do those tests’ expected images need to be updated?

3. What else do I need to do/be careful about before we submit the patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171113/d474de5b/attachment.html>