[Webkit-unassigned] [Bug 179488] Fix preload/picture-type.html to address race conditions with preloader and necessary DPR test setup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 10 14:00:27 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=179488

--- Comment #5 from Ryan Haddad <ryanhaddad at apple.com> ---
The test is still a flaky failure after this change:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r224702%20(5659)/results.html

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/preload/picture-type-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/preload/picture-type-actual.txt
@@ -1,40 +1,41 @@
-PASS internals.isPreloaded('resources/base-image1.png?0'); is true
+FAIL internals.isPreloaded('resources/base-image1.png?0'); should be true. Was false.
 PASS internals.isPreloaded('resources/preload-test.jpg?0'); is false
-PASS internals.isPreloaded('resources/base-image1.png?1'); is true
+FAIL internals.isPreloaded('resources/base-image1.png?1'); should be true. Was false.
 PASS internals.isPreloaded('resources/preload-test.jpg?1'); is false
-PASS internals.isPreloaded('resources/base-image1.png?2'); is true
+FAIL internals.isPreloaded('resources/base-image1.png?2'); should be true. Was false.
 PASS internals.isPreloaded('resources/preload-test.jpg?2'); is false
 PASS internals.isPreloaded('resources/base-image1.png?3'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?3'); is true
+FAIL internals.isPreloaded('resources/preload-test.jpg?3'); should be true. Was false.
 PASS internals.isPreloaded('resources/base-image1.png?4'); is false
 PASS internals.isPreloaded('resources/base-image2.png?4'); is false
-PASS internals.isPreloaded('resources/base-image3.png?4'); is true
+FAIL internals.isPreloaded('resources/base-image3.png?4'); should be true. Was false.
 PASS internals.isPreloaded('resources/preload-test.jpg?4'); is false
 PASS internals.isPreloaded('resources/base-image1.png?5'); is false
 PASS internals.isPreloaded('resources/base-image2.png?5'); is false
 PASS internals.isPreloaded('resources/base-image3.png?5'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?5'); is true
-PASS internals.isPreloaded('resources/base-image1.png?6'); is true
+FAIL internals.isPreloaded('resources/preload-test.jpg?5'); should be true. Was false.
+FAIL internals.isPreloaded('resources/base-image1.png?6'); should be true. Was false.
 PASS internals.isPreloaded('resources/preload-test.jpg?6'); is false
 PASS internals.isPreloaded('resources/base-image1.png?7'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?7'); is true
-PASS internals.isPreloaded('resources/base-image1.png?8'); is true
+FAIL internals.isPreloaded('resources/preload-test.jpg?7'); should be true. Was false.
+FAIL internals.isPreloaded('resources/base-image1.png?8'); should be true. Was false.
 PASS internals.isPreloaded('resources/preload-test.jpg?8'); is false
 PASS internals.isPreloaded('resources/base-image1.png?9'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?9'); is true
-PASS internals.isPreloaded('resources/base-image1.png?10'); is true
+FAIL internals.isPreloaded('resources/preload-test.jpg?9'); should be true. Was false.
+FAIL internals.isPreloaded('resources/base-image1.png?10'); should be true. Was false.
 PASS internals.isPreloaded('resources/base-image2.png?10'); is false
 PASS internals.isPreloaded('resources/preload-test.jpg?10'); is false
 PASS internals.isPreloaded('resources/base-image1.png?11'); is false
-PASS internals.isPreloaded('resources/base-image2.png?11'); is true
+FAIL internals.isPreloaded('resources/base-image2.png?11'); should be true. Was false.
 PASS internals.isPreloaded('resources/preload-test.jpg?11'); is false
-PASS internals.isPreloaded('resources/base-image1.png?12'); is true
+FAIL internals.isPreloaded('resources/base-image1.png?12'); should be true. Was false.
 PASS internals.isPreloaded('resources/base-image2.png?12'); is false
 PASS internals.isPreloaded('resources/preload-test.jpg?12'); is false
 PASS internals.isPreloaded('resources/base-image1.png?13'); is false
 PASS internals.isPreloaded('resources/base-image2.png?13'); is false
-PASS internals.isPreloaded('resources/preload-test.jpg?13'); is true
+FAIL internals.isPreloaded('resources/preload-test.jpg?13'); should be true. Was false.
 PASS successfullyParsed is true
+Some tests failed.

 TEST COMPLETE

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171110/9dc6b834/attachment.html>


More information about the webkit-unassigned mailing list