[Webkit-unassigned] [Bug 179494] AX: AOM: Implement AccessibleNode class and support label and role attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179494

--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 326477
  --> https://bugs.webkit.org/attachment.cgi?id=326477
initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326477&action=review

> Source/WebCore/accessibility/AccessibleNode.h:45
> +typedef Variant<
> +    std::nullptr_t,
> +    String,
> +    bool,
> +    int
> +> PropertyValueVariant;

Please put this into a single line.

> Source/WebCore/accessibility/AccessibleNode.h:51
> +enum class AXPropertyValueKeys {
> +    kAXNone,
> +    kAXRole,
> +    kAXLabel
> +};

Please remove k prefix. We don't use that in WebKit's C++ code.
Also, there's no need prefix each value with AX since enum class requires the enum name as prefix whenever using them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171109/adb0d277/attachment.html>