[Webkit-unassigned] [Bug 179494] AX: AOM: Implement AccessibleNode class and support label and role attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179494

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326474|1                           |0
        is obsolete|                            |

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 326474
  --> https://bugs.webkit.org/attachment.cgi?id=326474
initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326474&action=review

> Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:145
> +    const AtomicString& ariaLabel = getPropertyStringValue(AXPropertyValueKeys::kAXLabel);

can we use a namespace to avoid appending AXPropertyValueKeys:: everywhere?

> Source/WebCore/accessibility/AccessibilityObject.cpp:2151
> +    if (!is<Element>(node))

we should do if (Element* element = this->element())
here

> Source/WebCore/accessibility/AccessibleNode.cpp:83
> +

is there a way to avoid encoding "StringValue" into the name and just have it choose the right type based on return type?

> Source/WebCore/accessibility/AccessibleNode.cpp:84
> +const String AccessibleNode::getAOMPropertyOrARIAAttributeStringValue(Element* element, AXPropertyValueKeys propertyKey)

this name is a bit of a mouthful
what if it was just

elementAttributeStringValue()

then what happens inside is the right thing, rather than the name enumerating the things that might happen inside of it

> Source/WebCore/accessibility/AccessibleNode.cpp:98
> +        return element->attributeWithoutSynchronization(roleAttr);

can we make the switch set the attributeName to a variable, then below that call 

element->attributeWithoutSynchronization(X);

one time

> Source/WebCore/accessibility/AccessibleNode.cpp:104
> +const String AccessibleNode::getStringProperty(Element* element, AXPropertyValueKeys propertyKey)

can this be a String&

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171109/342ff97b/attachment-0001.html>