[Webkit-unassigned] [Bug 179446] [JSC][MIPS] Use fcsr to check the validity of the result of trunc.w.d

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 9 10:00:33 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=179446

--- Comment #8 from Guillaume Emont <guijemont at igalia.com> ---
> 
> So here we would do as it is for MIPS V and newer, and add a guard for to
> handle the case with ISA<5. Something like the following:
> 
>    #if WTF_MIPS_ISA_AT_LEAST(5)
>        emitInst(0x44400000 | (rt << OP_SH_RT) | (fs << OP_SH_FS));
>    #else
>        emitInst(0x44400000 | (rt << OP_SH_RT) | (MIPSRegisters::fcsr <<
> OP_SH_FS));
>        switch (fs) {
>        case MIPSRegisters::fccr:
>            andi(rt, rt, FCSR_FCCR_BITMASK);
>            break;
That would be a little more complicated, as the bits in fccr are not in the same position as the equivalent bits in fcsr.
In any case, another consideration is whether we want to keep on supporting anything older than mips32. I personally only have mips32 devices to test things, our testbot is mips32, and I don't know whether anyone is interested in running WebKit on older generations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171109/d50d05ed/attachment.html>


More information about the webkit-unassigned mailing list