[Webkit-unassigned] [Bug 179285] [GTK] Add functionality to handle font sizes in points

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 9 09:49:20 PST 2017


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #326443|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 326443
  --> https://bugs.webkit.org/attachment.cgi?id=326443

View in context: https://bugs.webkit.org/attachment.cgi?id=326443&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Make sure to either use 'webkit-patch apply-from-bug' once you have r+ to get  your reviewer's name in the changelog, or else manually write your reviewer's name here... you already had r+ from Carlos, but now you've deleted it.

> Source/WebKit/UIProcess/API/wpe/WebKitSettings.h:435
> +WEBKIT_API guint32
> +webkit_settings_font_size_to_points                            (guint32 pixels);
> +
> +WEBKIT_API guint32
> +webkit_settings_font_size_to_pixels                            (guint32 points);

I think these should not be exposed at all on WPE, since they won't work properly. So remove them from this header, and guard the implementation of the functions swith #if PLATFORM(GTK) to ensure they're not exported.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171109/06402493/attachment.html>

More information about the webkit-unassigned mailing list