[Webkit-unassigned] [Bug 179475] [SOUP] Case of request headers depends on global state in libsoup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 9 07:44:17 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=179475

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |csaavedra at igalia.com,
                   |                            |mcatanzaro at igalia.com

--- Comment #1 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Wow, good find!

I don't think there is anything to change in WebKit here. Do you want to report this on GNOME Bugzilla?

Anyway, the fix would surely be in soup-message-headers.c:

static const char *
intern_header_name (const char *name, SoupHeaderSetter *setter)
{
        // ...

        if (!header_pool) {
                header_pool = g_hash_table_new (soup_str_case_hash, soup_str_case_equal);

        // ...
}

Presumably that would need to be changed to:

        header_pool = g_hash_table_new (g_str_hash, g_str_equal);

But we should probably audit other uses of soup_str_case_hash and soup_str_case_equal to ensure they are appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171109/58c0a2c4/attachment-0001.html>


More information about the webkit-unassigned mailing list