[Webkit-unassigned] [Bug 179285] [GTK] Add functionality to handle font sizes in points

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 8 05:32:04 PST 2017


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #326210|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 326210
  --> https://bugs.webkit.org/attachment.cgi?id=326210

View in context: https://bugs.webkit.org/attachment.cgi?id=326210&action=review

> Source/WebCore/platform/PlatformScreen.h:62
> +double screenGetDPI();


> Source/WebCore/platform/gtk/PlatformScreenGtk.cpp:96
> +    static const double millimetresPerInch = 25.4;
> +    static double cachedDPI = 0;

These should be moved below, right before they are used.

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:3290
> +guint32 webkit_settings_convert_pixels_to_points(guint32 pixels)

This is still a generic function, even if it's prefix with webkit_settings, what I meant was to use something like webkit_settings_font_size_to_points(), or similar, to make ti clear that this is expected to be used with font size settings.

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:3308
> +guint32 webkit_settings_convert_points_to_pixels(guint32 points)

And webkit_settings_font_size_to_pixels().

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171108/e987e42e/attachment.html>

More information about the webkit-unassigned mailing list