[Webkit-unassigned] [Bug 179285] [GTK] Add functionality to handle font sizes in points

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179285

--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 326210
  --> https://bugs.webkit.org/attachment.cgi?id=326210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326210&action=review

I like it. Nice and simple, easy to use, and documented in a logical place. First r=me. Carlos will give final approval.

I know it's sad to do a bunch of work, redo it again and again, and wind up committing a much simpler result. But that's how we wind up with excellent APIs.

> Source/WebCore/platform/wpe/PlatformScreenWPE.cpp:59
> +    notImplemented();

Please remove this line, it's badly-named and doesn't do what you think... I've never quite understood its intended use, but I guess it's intended to be a TODO for stuff that you intend to implement in the near future, or for stuff that should never be called due to lack of implementation on some port. But in this case, it's going to print spam when applications change their font settings, and we don't want that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171107/d2de8557/attachment.html>