[Webkit-unassigned] [Bug 179373] [GStreamer] Builds fails with ENABLE_VIDEO=OFF due to GStreamer usage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179373

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Adrian Perez from comment #0)
> The build error is as follows:
> 
>     In file included from
> DerivedSources/WebCore/unified-sources/UnifiedSource287.cpp:8:0:
>     ../Source/WebCore/page/DeprecatedGlobalSettings.cpp: In static member
> function ‘static void
> WebCore::DeprecatedGlobalSettings::setGStreamerEnabled(bool)’:
>     ../Source/WebCore/page/DeprecatedGlobalSettings.cpp:144:23: error:
> incomplete type ‘WebCore::HTMLMediaElement’ used in nested name specifier
>          HTMLMediaElement::resetMediaEngines();
>                            ^~~~~~~~~~~~~~~~~
> 
> The part of the code referenced above is guarded with “USE(GSTREAMER)”,
> but IIRC it used to be that building with “ENABLE_VIDEO=OFF” should not
> be using GStreamer at all.

ENABLE_WEB_AUDIO uses GStreamer too. I think the code should probably be guarded by #if ENABLE(VIDEO) || ENABLE(WEB_AUDIO). But please ask the multimedia team what they prefer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171107/5b1ac087/attachment.html>