[Webkit-unassigned] [Bug 169245] @media rules ignored in user agent style sheet html.css

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169245

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #326117|review?                     |review+
              Flags|                            |

--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 326117
  --> https://bugs.webkit.org/attachment.cgi?id=326117
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326117&action=review

> Source/WebCore/ChangeLog:9
> +        To support accessibility features allow non-trivial @media rules in user agent stylesheet.

need a comma after "features"

> Source/WebCore/ChangeLog:48
> +            Also march rules in userAgentMediaQueryStyle.

march -> match

> Source/WebCore/css/CSSDefaultStyleSheets.cpp:125
> +    // Rulesets for these can't be global and need to be build in document context.

build -> built

> Source/WebCore/css/CSSDefaultStyleSheets.cpp:127
> +        if (is<StyleRuleMedia>(*rule)) {

I suggest using "continue" for this, just like the other if statements below.

> Source/WebCore/css/CSSDefaultStyleSheets.h:50
> +    static void initDefaultStyle(const Element*);

I don’t understand what changed that makes this need to be public instead of private now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171106/3a3577d1/attachment.html>