[Webkit-unassigned] [Bug 179231] Preloader ignores type attribute on Source tag causing overdownloading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179231

Yoav Weiss <yoav at yoav.ws> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yoav at yoav.ws

--- Comment #7 from Yoav Weiss <yoav at yoav.ws> ---
Comment on attachment 325890
  --> https://bugs.webkit.org/attachment.cgi?id=325890
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325890&action=review

> Source/WebCore/ChangeLog:3
> +        Add mime type check to the picture source preloader to avoid greedy downloading.

Could you add a better description here?

> Source/WebCore/ChangeLog:11
> +        (WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):

Could you add a description to the functions?

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:224
> +                LOG(MediaQueries, "HTMLPreloadScanner %p processAttribute evaluating content type", this);

I don't think the LOG here is necessary

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171103/990bec0b/attachment.html>