[Webkit-unassigned] [Bug 142673] [GTK] Add settings to set font size in points, and deprecate the pixel size settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142673

--- Comment #35 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Gabriel Ivașcu from comment #33)
> Hmmm Michael explicitly said that the fields in the private structure are
> not guaranteed to be zero-initialized.

But see my next comment #19 where I corrected that to "I'm not sure". I think it's technically default-constructed, which is effectively the same. But certainly the fact that the struct is initially zero-initialized has no effect on its value after construction.

> I think keeping the old properties in pixels and only adding font size
> setter/getter in points partially defeats the purpose of this bug. One of
> the goals was to make users not have to handle pixel values anymore, by
> getting rid of the pixel properties eventually in the future. (The other
> goal was to make the text scale automatically when the DPI changes.)

But you don't have to handle pixels anymore if you use the functions. There's not really any compelling reason that the properties have to be used directly; it's just a bit more convenient when initializing the WebKitSettings object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171103/1e5dff4e/attachment.html>