[Webkit-unassigned] [Bug 164684] USE(APPLE_INTERNAL_SDK) should not be combined with other conditions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164684

--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
(In reply to mitz from comment #0)
> There are some instances of
>     #if USE(APPLE_INTERNAL_SDK) && …
> in the code base, but this is hardly ever the right thing to do.
> USE(APPLE_INTERNAL_SDK) really only makes sense as the innermost condition,
> and almost always has an #else clause that should not depend on anything
> other than the use of the internal SDK (but should just contain declarations
> that are equivalent to what the SDK provides).

Also, we should consider moving such #if #else into separate SPI.h headers.

Note: I just rebased and landed the old patch https://trac.webkit.org/changeset/224395 which adds more USE(APPLE_INTERNAL_SDK) to fix here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171103/37eaf728/attachment.html>