[Webkit-unassigned] [Bug 179014] Remove empty continuations in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179014

Ryan Haddad <ryanhaddad at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ryanhaddad at apple.com

--- Comment #20 from Ryan Haddad <ryanhaddad at apple.com> ---
30 LayoutTests are hitting an assertion failure after re-landing this change:

ASSERTION FAILED: !continuationChainNode.next->renderer->firstChild()
/Volumes/Data/slave/sierra-debug/build/Source/WebCore/rendering/RenderBoxModelObject.cpp(2539) : void WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations()
1   0x123078b5d WTFCrash
2   0x11831dd02 WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations()
3   0x1182f4490 WebCore::RenderBoxModelObject::willBeDestroyed()
4   0x1183b6048 WebCore::RenderInline::willBeDestroyed()
5   0x11846ba3e WebCore::RenderObject::destroy()
6   0x11846b8f9 WebCore::RenderObjectDeleter::operator()(WebCore::RenderObject*) const
7   0x118341c07 WebCore::RenderElement::removeAndDestroyChild(WebCore::RenderObject&)
8   0x11846497c WebCore::RenderObject::removeFromParentAndDestroy()
9   0x11847111f WebCore::RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers()
10  0x118673ceb WebCore::RenderTreeUpdater::tearDownRenderers(WebCore::Element&, WebCore::RenderTreeUpdater::TeardownType)::$_8::operator()(unsigned int) const
11  0x118671393 WebCore::RenderTreeUpdater::tearDownRenderers(WebCore::Element&, WebCore::RenderTreeUpdater::TeardownType)
12  0x118673bc7 WebCore::RenderTreeUpdater::tearDownRenderers(WebCore::Element&)
13  0x11747f7ec WebCore::Document::destroyRenderTree()
14  0x11747fb7a WebCore::Document::prepareForDestruction()
15  0x117c9e180 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView>&&)
16  0x117ca0753 WebCore::Frame::createView(WebCore::IntSize const&, WebCore::Color const&, bool, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool)
17  0x10d2af772 WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage()
18  0x117b263d6 WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*)
19  0x117b2546a WebCore::FrameLoader::commitProvisionalLoad()
20  0x117adad2c WebCore::DocumentLoader::commitIfReady()
21  0x117adb052 WebCore::DocumentLoader::finishedLoading()
22  0x117ae2ba5 WebCore::DocumentLoader::maybeLoadEmpty()
23  0x117ae2d2d WebCore::DocumentLoader::startLoadingMainResource()
24  0x117b40814 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL)::$_8::operator()() const
25  0x117b40559 WTF::Function<void ()>::CallableWrapper<WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL)::$_8>::call()
26  0x11585effb WTF::Function<void ()>::operator()() const
27  0x117b237cd WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL)
28  0x117b3f148 WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WebCore::FormState*, WebCore::AllowNavigationToInvalidURL)::$_6::operator()(WebCore::ResourceRequest const&, WebCore::FormState*, bool) const
29  0x117b3f0d2 WTF::Function<void (WebCore::ResourceRequest const&, WebCore::FormState*, bool)>::CallableWrapper<WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WebCore::FormState*, WebCore::AllowNavigationToInvalidURL)::$_6>::call(WebCore::ResourceRequest const&, WebCore::FormState*, bool)
30  0x117b6b92d WTF::Function<void (WebCore::ResourceRequest const&, WebCore::FormState*, bool)>::operator()(WebCore::ResourceRequest const&, WebCore::FormState*, bool) const
31  0x117b621b9 WTF::CompletionHandler<void (WebCore::ResourceRequest const&, WebCore::FormState*, bool)>::operator()(WebCore::ResourceRequest const&, WebCore::FormState*, bool)
LEAK: 1 WebPageProxy

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r224329%20(3837)/results.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171102/6221afab/attachment-0001.html>