[Webkit-unassigned] [Bug 179020] [Touch Bar Web API] Add support for menuitem tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179020

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325482|review?                     |review+
              Flags|                            |

--- Comment #35 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 325482
  --> https://bugs.webkit.org/attachment.cgi?id=325482
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325482&action=review

> Source/WebCore/ChangeLog:12
> +        is set to false by default.  

Nits: There are two trailing spaces here.

> Source/WebCore/ChangeLog:13
> +

Please add some references to old HTML specifications like https://www.w3.org/TR/2013/WD-html51-20130528/interactive-elements.html.

> Source/WebKit/ChangeLog:8
> +        Adds in the MenuItemEnabled flag and default value. 

Nit: A trailing space at the end.

> Source/WebCore/html/HTMLMenuItemElement.idl:27
> +] interface HTMLMenuItemElement : HTMLElement {

So the idea is to implement more attributes of https://www.w3.org/TR/2013/WD-html51-20130528/interactive-elements.html in the future patches?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171101/98710eb2/attachment.html>