[Webkit-unassigned] [Bug 179132] Web Inspector: Move InspectorAgents into a folder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 1 12:08:19 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=179132

Build Bot <buildbot at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |buildbot at hotmail.com

--- Comment #2 from Build Bot <buildbot at hotmail.com> ---
Attachment 325608 did not pass style-queue:


ERROR: Source/WebCore/inspector/agents/InspectorPageAgent.cpp:205:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:451:  'document' is incorrectly named. It should be named 'protector' or 'protectedDocument'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:583:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:601:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:612:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:1015:  'node' is incorrectly named. It should be named 'protector' or 'protectedInspectedNode'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:1553:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:2017:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:2018:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp:702:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/inspector/agents/page/PageDebuggerAgent.h:88:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 11 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171101/601d5954/attachment-0001.html>


More information about the webkit-unassigned mailing list