[Webkit-unassigned] [Bug 175275] [Win] Detect Visual Studio 2017 location

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175275

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325591|review?                     |review+
              Flags|                            |

--- Comment #37 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 325591
  --> https://bugs.webkit.org/attachment.cgi?id=325591
Use vswhere to determine visual studio location - make new modules require only in new paths

View in context: https://bugs.webkit.org/attachment.cgi?id=325591&action=review

> Tools/Scripts/webkitdirs.pm:600
> +    require Encode;
> +    require Encode::Locale;
> +    require JSON::PP;

Let's extract this part to a subroutine.

> Tools/Scripts/webkitdirs.pm:639
> +    require Encode;
> +    require Encode::Locale;
> +    require JSON::PP;

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171101/a73d3fc4/attachment.html>