[Webkit-unassigned] [Bug 172687] Can't use Object.defineProperty() to add an item to a DOMStringMap or Storage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 31 15:00:20 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=172687

--- Comment #5 from Saam Barati <sbarati at apple.com> ---
(In reply to Sam Weinig from comment #4)
> Yeah, I'm just going to implement the defineOwnProperty hook. One issue
> though is that as specified, I need to modify the PropertyDescriptor (see
> step 3 of
> https://heycam.github.io/webidl/#legacy-platform-object-defineownproperty)
> but the hook passes it as a const reference. Seems relatively
> straightforward to change this in JSC, but I am not clear if that was done
> for a reason.

I'm not sure why JSC passes it as const. However, why not just create a new one? I think that should be pretty cheap.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170531/a5e93287/attachment.html>


More information about the webkit-unassigned mailing list