[Webkit-unassigned] [Bug 172596] Crash on display-contents-replaced-001.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 30 01:50:13 PDT 2017


--- Comment #8 from Emilio Cobos Álvarez <ecobos at igalia.com> ---
(In reply to Antti Koivisto from comment #5)
> (In reply to Emilio Cobos Álvarez from comment #4)
> > Note that the spec requires contents to still compute to contents, which I
> > don't think will be true with this patch.
> > 
> > i.e., a test like:
> > 
> > var svg = document.querySelector('svg');
> > svg.style.display = "contents";
> > getComputedStyle(svg).display; // "none" with your patch, "contents" per
> > spec.
> Is the spec correct though? We generally return the effective display value
> from getComputedStyle rather than the original. We already save the original
> in RenderStyle so if we want we could add a bit that says "return original
> instead of effective" to fix this.

Hmmm... Yeah, perhaps it's just easier to lie in getComputedStyle if needed.

If you feel very strongly about it feel free to write something in https://github.com/w3c/csswg-drafts/issues/540 (or raise another issue). Otherwise I'll take care of the tests and the getComputedStyle stuff if needed.

> > I had a WIP patch that did this[1]. Pending thing was to address the
> > special-cases you mention in your FIXME.
> I'd like to use a blacklist like in my patch instead of virtuals. It is much
> easier to compare the code to the spec. A bigger problem with your approach
> is that we have a bunch of sites that explicitly test for display() ==/!=
> NONE (and some for CONTENTS) and there is no way to know they should behave
> like 'none' in the effective case.
> Does this make sense to you?

Yeah, that makes sense, thanks for looking into it :)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170530/ba4e5960/attachment.html>

More information about the webkit-unassigned mailing list