[Webkit-unassigned] [Bug 171997] navigator.webdriver should return false if the page is not controlled by automation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171997

--- Comment #35 from Chris Dumez <cdumez at apple.com> ---
(In reply to David Kilzer (:ddkilzer) from comment #34)
> (In reply to WebKit Commit Bot from comment #32)
> > Comment on attachment 311015 [details]
> > Patch
> > 
> > Clearing flags on attachment: 311015
> > 
> > Committed r217391: <http://trac.webkit.org/changeset/217391>
> 
> This appears to have broken the build on our internal clang static analyzer
> bot:
> 
> Undefined symbols for architecture x86_64:
>   "WebCore::JSNavigator::webdriver(JSC::ExecState&) const", referenced from:
>       WebCore::jsNavigatorWebdriverGetter(JSC::ExecState&,
> WebCore::JSNavigator&, JSC::ThrowScope&) in JSNavigator.o
> ld: symbol(s) not found for architecture x86_64
> 
> I'm not sure why this hasn't been seen on any other bots, though, except
> GTK+ EWS (although trunk builders seem fine):
> 
> lib/libWebCoreDerivedSources.a(lib/../Source/WebCore/CMakeFiles/
> WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSNavigator.cpp.o):
> JSNavigator.cpp:function WebCore::jsNavigatorWebdriver(JSC::ExecState*,
> long, JSC::PropertyName): error: undefined reference to
> 'WebCore::JSNavigator::webdriver(JSC::ExecState&) const'
> collect2: error: ld returned 1 exit status
> 
> Maybe it needs a clean build?

Yes, likely needs a clean build.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170525/3307e657/attachment.html>