[Webkit-unassigned] [Bug 172553] [CMake] Wrap CODE_GENERATOR_PREPROCESSOR_EXECUTABLE on Windows hosts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172553

Don Olmstead <don.olmstead at am.sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|webkit-unassigned at lists.web |don.olmstead at am.sony.com
                   |kit.org                     |

--- Comment #1 from Don Olmstead <don.olmstead at am.sony.com> ---
Created attachment 311148

  --> https://bugs.webkit.org/attachment.cgi?id=311148&action=review

Patch

Uses CMAKE_HOST_WIN32 https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_WIN32.html to identify a build happening on a Windows machine. This detects cygwin as well. From there the command is wrapped in quotes just in case there are spaces.

This is useful for anyone cross compiling WebKit on Windows such as what we're doing on the PlayStation.

Also removed a stale comment.

Going to wait on the apple win bots before reviewing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170524/23d871a7/attachment.html>