[Webkit-unassigned] [Bug 171997] navigator.webdriver should return false if the page is not controlled by automation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 22 14:21:47 PDT 2017


Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
 Attachment #310918|review?                     |review-
              Flags|                            |

--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 310918
  --> https://bugs.webkit.org/attachment.cgi?id=310918

View in context: https://bugs.webkit.org/attachment.cgi?id=310918&action=review

Patch looks good otherwise.

> Source/WebCore/ChangeLog:5
> +        Per WebDriver Specification at https://www.w3.org/TR/webdriver/#interface

The description should come *after* the reviewed by line.

> Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp:52
> +    Frame* frame = navigator.frame();


> Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp:53
> +    if (frame || !frame->page())

This check seems wrong, should probably !frame.

> LayoutTests/js/dom/navigator-webdriver.html:8
> +description(

Just description("Check that navigator.webdriver has the right attributes.");

> LayoutTests/js/dom/navigator-webdriver.html:12
> +if (window.testRunner) {

We don't use curly brackets for one-liners.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170522/b837392a/attachment.html>

More information about the webkit-unassigned mailing list