[Webkit-unassigned] [Bug 159631] [GTK] Add webkit_context_menu_item_new_from_gaction

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 20 06:47:52 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #310648|review?                     |review+
              Flags|                            |

--- Comment #19 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 310648
  --> https://bugs.webkit.org/attachment.cgi?id=310648

View in context: https://bugs.webkit.org/attachment.cgi?id=310648&action=review

Nice! Reasoning about actions is tricky.

We really ought to deprecate webkit_context_menu_item_new() and webkit_context_menu_item_get_action() in this patch. Deprecations are an optional service to let developers know that the function is going away eventually and ease porting to our future GTK+ API. It doesn't mean developers have to immediately stop using them; of course we'll keep them working in our GTK+ 3 API forever. But we are for sure that the GtkAction version of this function is going to be gone in our GTK+ 4 API, so best let developers know that now. r=me if you add deprecations for these two functions (both header file attributes and introspection annotations).

> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:84
> +        if (menuItem.action() < ContextMenuItemBaseApplicationTag) {

Why did you have to add this conditional?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170520/79e0e6c6/attachment-0001.html>

More information about the webkit-unassigned mailing list