[Webkit-unassigned] [Bug 172368] Fix `make distcheck` by including Tools/TestRunnerShared

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172368

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310674|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 310674
  --> https://bugs.webkit.org/attachment.cgi?id=310674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310674&action=review

> Tools/gtk/make-dist.py:247
> -        command = ['cmake', '-DPORT=%s' % port, '-DCMAKE_INSTALL_PREFIX=%s' % install_dir, '-DCMAKE_BUILD_TYPE=Release', dist_dir]
> +        command = ['cmake', '-DPORT=%s' % port, '-DCMAKE_INSTALL_PREFIX=%s' % install_dir, '-DCMAKE_BUILD_TYPE=Release', '-DDEVELOPER_MODE=ON', dist_dir]

The point of make distcheck is precisely to make a production build, ensuring it builds without the developer mode.

> Tools/gtk/manifest.txt.in:88
> +directory Tools/TestRunnerShared

I don't know why we are including WTR in the tarball, because I don't think it's possible to run layout tests from a tarball anyway, since we are not including all the webkitpy and tools required. I think the right fix for this is to remove ImageDiff, WTR and DRT from the tarball. Only unit tests should be included, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170520/43baf4ee/attachment.html>