[Webkit-unassigned] [Bug 172412] New: Switch windows build to Visual Studio 2017

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172412

            Bug ID: 172412
           Summary: Switch windows build to Visual Studio 2017
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Windows 10
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: isaac+webkit at devinesystems.co.nz

Created attachment 310766

  --> https://bugs.webkit.org/attachment.cgi?id=310766&action=review

Patch to change to use Visual Studio 2017 for building

Switch the target compiler and build environment to Visual Studio 2017.

N.B. The attached patch seems to cause MiniBrowser at startup with the following stack trace:
WebKit\WebKitBuild\Debug\DerivedSources\WebCore\HTMLNames.cpp

        WTF.dll!WTFCrash() Line 292     C++
        WebKit.dll!WTF::StringImpl::assertHashIsCorrect() Line 889      C++
>	WebKit.dll!WebCore::HTMLNames::init() Line 1666	C++
        WebKit.dll!WebCore::Frame::Frame(WebCore::Page & page, WebCore::HTMLFrameOwnerElement * ownerElement, WebCore::FrameLoaderClient & frameLoaderClient) Line 175  C++
        WebKit.dll!WebCore::MainFrame::MainFrame(WebCore::Page & page, WebCore::PageConfiguration & configuration) Line 56      C++
        WebKit.dll!WebCore::MainFrame::create(WebCore::Page & page, WebCore::PageConfiguration & configuration) Line 68 C++
        WebKit.dll!WebCore::Page::Page(WebCore::PageConfiguration && pageConfiguration) Line 270        C++
        WebKit.dll!WebView::initWithFrame(tagRECT frame, wchar_t * frameName, wchar_t * groupName) Line 3122    C++
        MiniBrowserLib.dll!MiniBrowser::prepareViews(HWND__ * mainWnd, const tagRECT & clientRect, wchar_t * const & requestedURL, HWND__ * & viewHwnd) Line 100        C++
        MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 160        C++
        MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 857   C++
        MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 249   C++

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170520/2d990a3d/attachment.html>