[Webkit-unassigned] [Bug 172390] New: [iOS]: RunLoop::main().dispatch() needs to take into account USE_WEB_THREAD

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 19 15:06:39 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=172390

            Bug ID: 172390
           Summary: [iOS]: RunLoop::main().dispatch() needs to take into
                    account USE_WEB_THREAD
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: joepeck at webkit.org
                CC: aestes at apple.com, andersca at apple.com,
                    cdumez at apple.com, ddkilzer at webkit.org

[iOS]: RunLoop::main().dispatch() needs to take into account WEB_THREAD

There are cases of RunLoop::main().dispatch() in WebCore that may not be safe if USE_WEB_THREAD

    bindings/js/SerializedScriptValue.cpp
    3166:    RunLoop::main().dispatch([this, conditionPtr = &condition, valuePtr = &value] {

    Modules/applepay/ApplePaySession.cpp
    640:        RunLoop::main().dispatch([promise, canMakePayments]() mutable {

    workers/WorkerMessagingProxy.cpp
    168:    RunLoop::main().dispatch([this, protectedThis = makeRef(*this), message = message.isolatedCopy()] {

If possible callOnMainThread could be used or WebThreadRun. See Modules/websockets/WebSocket.cpp's approach.

Note: WorkerMessagingProxy case, callOnMainThread couldn't be used and was specifically avoided.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170519/6a66e1b8/attachment.html>


More information about the webkit-unassigned mailing list