[Webkit-unassigned] [Bug 172267] [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172267

--- Comment #10 from Yusuke Suzuki <utatane.tea at gmail.com> ---
(In reply to Per Arne Vollan from comment #9)
> (In reply to Fujii Hironori from comment #8)
> > Created attachment 310635 [details]
> > WIP patch
> > 
> > (In reply to Per Arne Vollan from comment #6)
> > > Perhaps we shouldn't link with both WebKit.lib and WebCore.lib? In theory, I
> > > guess TestWebCoreLib only needs to link with WebCore.lib, and TestWebKitLib
> > > only needs to link with WebKit.lib. I would expect to get many other linker
> > > errors if this was the case, though.
> > 
> > Sounds good!
> > Unfortunately, my WIP patch reports a following linkage error.
> > 
> > > ------ Build started: Project: TestWebCoreLib, Configuration: Debug x64 ------
> > >      Creating library C:/webkit/ga/WebKitBuild/Debug/lib64/TestWebCoreLib.lib and object C:/webkit/ga/WebKitBuild/Debug/lib64/TestWebCoreLib.exp
> > > WebCore.lib(ImageWin.obj) : error LNK2019: unresolved external symbol "class WTF::RefPtr<class WebCore::SharedBuffer> __cdecl loadResourceIntoBuffer(char const *)" (?loadResourceIntoBuffer@@YA?AV?$RefPtr at VSharedBuffer@WebCore@@@WTF@@PEBD at Z) referenced in function "public: static class WTF::Ref<class WebCore::Image> __cdecl WebCore::Image::loadPlatformResource(char const *)" (?loadPlatformResource at Image@WebCore@@SA?AV?$Ref at VImage@WebCore@@@WTF@@PEBD at Z)
> > > C:\webkit\ga\WebKitBuild\Debug\bin64\TestWebCoreLib.dll : fatal error LNK1120: 1 unresolved externals
> > > ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
> > 
> > There is a layer violation.
> 
> Nice work! I suggest soft linking the loadResourceIntoBuffer function.

Yeah, that's great!
In the meantime, I'll land the original patch by extracting checkSubClassPatchpoint from JSNode / JSDocument and move it to WebCore::checkSubClassPatchpointFor{JSNode,JSDocument}.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170519/ec6430aa/attachment.html>