[Webkit-unassigned] [Bug 171997] navigator.webdriver should return false if the page is not controlled by automation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171997

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310570|review?                     |review-
              Flags|                            |

--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 310570
  --> https://bugs.webkit.org/attachment.cgi?id=310570
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310570&action=review

This needs a layout test to check that:
1. The property is false instead of being undefined now
2. The property is not configurable (Assuming this part of your change is right)
3. The property is enumerable (as I think it should be as per the spec).

> Source/WebCore/ChangeLog:8
> +

Please add a link to the spec in your changelog.

> Source/WebCore/Modules/webdriver/NavigatorWebDriver.idl:27
> +    [Unforgeable, NotEnumerable, Custom] readonly attribute boolean webdriver;

We no longer need custom code at all. [Custom] should be dropped and the implementation should be updated accordingly.

Could you also point to the spec that says it should be Unforgeable? I do know that [NotEnumerable] is not as per spec and should be dropped but last time I checked, there was no [Unforgeable] in the spec.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170518/720d44a1/attachment.html>