[Webkit-unassigned] [Bug 172317] [CMake] Add HAVE check for __int128_t

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 18 15:31:57 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=172317

Don Olmstead <don.olmstead at am.sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|webkit-unassigned at lists.web |don.olmstead at am.sony.com
                   |kit.org                     |

--- Comment #2 from Don Olmstead <don.olmstead at am.sony.com> ---
Created attachment 310558

  --> https://bugs.webkit.org/attachment.cgi?id=310558&action=review

Patch

This patch adds a HAVE check for __int128_t. I did not want to do a COMPILER check because clang-cl shows up as both Clang and MSVC so a HAVE check is the best choice. A patch for clang-cl support is coming in the near future.

Currently GCC and Clang expose this. It appears this is exposed only on x64 according to GCC docs https://gcc.gnu.org/onlinedocs/gcc/_005f_005fint128.html. I also saw that clang-cl seems to have that behavior as it does not expose it for x86 builds but does for x64.

I don't believe that the Intel compiler exposes this value in case anyone is using that.

The Platform.h file is modified within the block that has all the corresponding HAVE checks in OptionsCommon. This is to support DARWIN targets that are not using CMake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170518/509972a3/attachment.html>


More information about the webkit-unassigned mailing list