[Webkit-unassigned] [Bug 172248] [Win] Support $vm.getpid()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 17 15:37:04 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=172248

Don Olmstead <don.olmstead at am.sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|webkit-unassigned at lists.web |don.olmstead at am.sony.com
                   |kit.org                     |

--- Comment #1 from Don Olmstead <don.olmstead at am.sony.com> ---
Created attachment 310452

  --> https://bugs.webkit.org/attachment.cgi?id=310452&action=review

Patch

The original bug https://bugs.webkit.org/show_bug.cgi?id=163493 did not go for a windows implementation because of restrictions in getpid and _getpid. From MSDN https://docs.microsoft.com/en-us/cpp/cppcx/crt-functions-not-supported-in-universal-windows-platform-apps it appears that both _getpid and getpid should just use GetCurrentProcessId so getProcessId from ProcessID.h can be used since it calls that.

Found this while trying to compile out JSCOnly on Windows. It fails on this file because PLATFORM(WIN) is used instead of OS(WINDOWS).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170517/d062f1c7/attachment.html>


More information about the webkit-unassigned mailing list