[Webkit-unassigned] [Bug 172167] [Threaded Compositor] SHOULD NEVER BE REACHED in WebKit::CompositingRunLoop::updateCompleted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172167

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Zan Dobersek from comment #6)
> Comment on attachment 310260 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310260&action=review
> 
> > Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:266
> > -    sceneUpdateFinished();
> > +    if (m_scene->isActive())
> > +        sceneUpdateFinished();
> 
> How can this occur? renderLayerTree() returns early at the beginning if the
> scene is not active. If it is active, the function then executes serially,
> which should make it impossible for any task to be scheduled on this thread
> that would make the scene inactive.

Because invalidate happens in the main thread.

> > Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:292
> > +        // Do not change m_coordinateUpdateCompletionWithClient while in force repaint.
> > +        if (m_inForceRepaint)
> > +            return;
> 
> m_coordinateUpdateCompletion should be set here, but to false if
> m_inForceRepaint is false as well.

That happens, because it doesn't return early.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170517/8628360c/attachment.html>