[Webkit-unassigned] [Bug 172209] New: EventHandler::selectCursor should not select a custom cursor its image is not loaded yet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172209

            Bug ID: 172209
           Summary: EventHandler::selectCursor should not select a custom
                    cursor its image is not loaded yet
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Event Handling
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com

I tested with WinCairo port, debug build, trunk at 216964.
I see the following assertion failure while moving cursor in Google maps.

> ASSERTION FAILED: bmp
> C:\webkit\ga\Source\WebCore\platform\graphics\win\ImageCairoWin.cpp(60) : WebCore::BitmapImage::getHBITMAPOfSize

Callstack:

> WTF.dll!WTFCrash() Line 292	C++
> WebKit.dll!WebCore::BitmapImage::getHBITMAPOfSize(HBITMAP__ * bmp, const WebCore::IntSize * size) Line 60	C++
> WebKit.dll!WebCore::BitmapImage::getHBITMAP(HBITMAP__ * bmp) Line 52	C++
> WebKit.dll!WebCore::createSharedCursor(WebCore::Image * img, const WebCore::IntPoint & hotSpot) Line 70	C++
> WebKit.dll!WebCore::Cursor::ensurePlatformCursor() Line 260	C++
> WebKit.dll!WebCore::Cursor::platformCursor() Line 186	C++
> WebKit.dll!WebChromeClient::setCursor(const WebCore::Cursor & cursor) Line 693	C++
> WebKit.dll!WebCore::Chrome::setCursor(const WebCore::Cursor & cursor) Line 466	C++
> WebKit.dll!WebCore::Widget::setCursor(const WebCore::Cursor & cursor) Line 76	C++
> WebKit.dll!WebCore::EventHandler::updateCursor(WebCore::FrameView & view, const WebCore::HitTestResult & result, bool shiftKey) Line 1374	C++
> WebKit.dll!WebCore::EventHandler::handleMouseMoveEvent(const WebCore::PlatformMouseEvent & platformMouseEvent, WebCore::HitTestResult * hoveredNode, bool onlyUpdateScrollbars) Line 1974	C++
> WebKit.dll!WebCore::EventHandler::mouseMoved(const WebCore::PlatformMouseEvent & event) Line 1838	C++
> WebKit.dll!WebView::handleMouseEvent(unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 1884	C++
> WebKit.dll!WebView::WebViewWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 2607	C++
> [External Code]	
> WebKit.dll!WebCore::WindowMessageBroadcaster::SubclassedWndProc(HWND__ * hwnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 125	C++
> [External Code]	
> WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 97	C++
> MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 189	C++
> MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 857	C++
> MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 249	C++
> [External Code]	

The cursor image wasn't loaded yet at the time.
EventHandler::selectCursor returns nullImage in such case.

There are two choices of solution:

  1. EventHandler::selectCursor should not select a custom cursor its image is not loaded yet
  2. Windows port should handle nullImage cursor

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170517/2cb0704b/attachment.html>