[Webkit-unassigned] [Bug 171927] ASSERTION FAILED in WebCore::AccessibilityNodeObject::insertChild()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 16 17:06:55 PDT 2017


--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
(In reply to Nan Wang from comment #5)
> Comment on attachment 310317 [details]
> patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310317&action=review
> >> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:371
> >> +    } else if (child->parentObject() == this)
> > 
> > should we leave this check in place and instead return nil for this case in nextSibling()?
> I think there might be case somewhere we actually want the sibling element.

can we detect the bad case and return nil from nextSibling()? then we can leave the assert in place that finds elements with bad parents.

because with this we are going to essentially throw away those elements anyway since they don't get inserted into the tree

or do we have an issue where we don't want this current nextSibling() but if we did

nextSibling()->nextSibling() that's a good element?

if that's the case, can we just do nextSibling()->nextSibling() inside nextSibling() ?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170517/d5398082/attachment-0001.html>

More information about the webkit-unassigned mailing list