[Webkit-unassigned] [Bug 171984] Add a RuntimeEnabledFeature for display: contents

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 14 03:54:08 PDT 2017


--- Comment #20 from Emilio Cobos Álvarez <ecobos at igalia.com> ---
(In reply to Ryosuke Niwa from comment #13)
> Comment on attachment 309797 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309797&action=review
> > Source/WebCore/ChangeLog:11
> > +        Add a RuntimeEnabledFeature for display: contents, defaulted to false.
> > +
> > +        The "defaulted to false" is not only because there are spec issues, but because
> > +        I ran the WPT suite, and there was a fair amount of crashes and messed render
> > +        trees.
> > +
> > +        https://bugs.webkit.org/show_bug.cgi?id=171984
> > +
> > +        Reviewed by Antti Koivisto.
> Change log here is really messed up.
> The bug title should be followed by a bug URL, followed by a blank line,
> then a long description.

Thanks for the heads-up, prepare-ChangeLog posted the whole git commit description before the url field, and no script complained about it, so I just assumed it was fine. I updated and amended it.

(In reply to Sam Weinig from comment #18)
> Is there any reason this need to be a RuntimeEnabledFeature rather than a
> Setting?

>From a quick look RuntimeEnabledFeatures it what's usually used for web features, but happy to change it if there's a good reason to.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170514/e35aadee/attachment.html>

More information about the webkit-unassigned mailing list