[Webkit-unassigned] [Bug 167962] [ESnext] Implement Object Rest - Implementing Object Rest Destructuring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 12 09:22:56 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=167962

--- Comment #46 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 303896
  --> https://bugs.webkit.org/attachment.cgi?id=303896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303896&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:1017
>> +                if (kind == DestructuringKind::DestructureToExpressions && !innerPattern)
> 
> This line of code looks wrong. Why do we only care about DestructureToExpressions?

I think you are right. We should care about other cases as well IMHO. I'm going to handle that in another bug.

Also I don't remember any test to check the condition when innerPatter != null. We are missing this piece of code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170512/97f98564/attachment.html>


More information about the webkit-unassigned mailing list