[Webkit-unassigned] [Bug 170432] [GTK] GIF images are not properly loaded the first time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170432

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Fujii Hironori from comment #12)
> WinCairo port can't show all GIF from http: due to this bug but from file:.
> I think it's because curl port uses small buffer size.
> 
> BTW, I have a question. Looking at the source code comment
> in Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:
> 
> >        case GIFGlobalHeader: {
> >            // This is the height and width of the "screen" or frame into which images are rendered. The
> >            // individual images can be smaller than the screen size and located with an origin anywhere
> >            // within the screen.
> >            m_screenWidth = GETINT16(currentComponent);
> >            m_screenHeight = GETINT16(currentComponent + 2);
> >
> >            // CALLBACK: Inform the decoderplugin of our size.
> >            // Note: A subsequent frame might have dimensions larger than the "screen" dimensions.
> >            if (m_client && !m_client->setSize(WebCore::IntSize(m_screenWidth, m_screenHeight)))
> >                return false;
> 
> It seems that decoder's size is the screen size.
> 
> Real individual image size seems the size specified in
> GIFImageDecoder::initFrameBuffer.
> 
> >    buffer->backingStore()->setFrameRect(IntRect(left, top, right - left, bottom - top));

I don't think there's any problem, because we are not caching that size, when frames are available, the actual frame sizes will be used instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170512/11b8412e/attachment-0001.html>