[Webkit-unassigned] [Bug 170762] Updating class name of a shadow host does not update the style applied by descendants of :host()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 11 14:17:19 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #309710|review?                     |review+
              Flags|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 309710
  --> https://bugs.webkit.org/attachment.cgi?id=309710

View in context: https://bugs.webkit.org/attachment.cgi?id=309710&action=review

> Source/WebCore/css/RuleSet.cpp:208
> +    return leftmostSelector->match() == CSSSelector::PseudoClass && leftmostSelector->pseudoClassType() ==CSSSelector::PseudoClassHost;

Nit: Need a space after the second ==.

> Source/WebCore/css/RuleSet.h:218
> +    bool m_hasHostPseudoClassRulesMatchingInShadowTree { false };

You might wanna put this next to another boolean for better packing not that it matters much.

> LayoutTests/fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html:108
> +test("#host4", "#shadow4", (host) => {
> +   host.setAttribute('id','green');
> +});

Could you also add a variant for modifying ID/class/attribute of a node inside the shadow tree?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170511/c6ac0250/attachment-0001.html>

More information about the webkit-unassigned mailing list