[Webkit-unassigned] [Bug 170432] [GTK] GIF images are not properly loaded the first time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170432

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309704|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 309704
  --> https://bugs.webkit.org/attachment.cgi?id=309704
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309704&action=review

Amazing!

> Source/WebCore/platform/graphics/ImageFrameCache.cpp:482
> +#if !USE(CG)
> +    if (m_frames.isEmpty() && isDecoderAvailable())
> +        return m_decoder->size();
> +#endif

I think we should add a comment here briefly mentioning the tricky issue explained on the changelog for the next developer that touches this code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170511/2a815872/attachment.html>